Issue 10825213: Cause chrome.exe to introspect to find the version of chrome.dll to load. This should ensure that m…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825213: Cause chrome.exe to introspect to find the version of chrome.dll to load. This should ensure that m… (Closed)

Created:
8 years, 4 months ago by robertshield

Modified:
8 years, 4 months ago

Reviewers:
gab, cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, grt (UTC plus 2)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cause chrome.exe to introspect to find the version of chrome.dll to load. This should ensure that mismatched exe and dll versions never occur. Also, wstring -> string16. BUG=140779 TEST=Install Chrome, smash Omaha registry keys, Chrome still runs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150282

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unneeded header. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -33 lines)			Patch
	M	chrome/app/client_util.h	View	1	3 chunks	+8 lines, -7 lines	0 comments	Download
	M	chrome/app/client_util.cc	View		13 chunks	+43 lines, -26 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

gab

OMG lgtm :)! https://chromiumcodereview.appspot.com/10825213/diff/1/chrome/app/client_util.h File chrome/app/client_util.h (right): https://chromiumcodereview.appspot.com/10825213/diff/1/chrome/app/client_util.h#newcode12 chrome/app/client_util.h:12: #include <string> nit: You no longer ...

8 years, 4 months ago (2012-08-07 03:34:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/10825213/6001

8 years, 4 months ago (2012-08-07 03:46:54 UTC) #4

Change committed as 150282

Expand Messages | Collapse Messages