Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 10825210: Accelerator support for browserless panels on Windows. (Closed)

Created:
8 years, 4 months ago by jianli
Modified:
8 years, 4 months ago
Reviewers:
jennb
CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng
Visibility:
Public.

Description

Patch Set 1 : Patch #

Total comments: 1

Patch Set 2 : Use static table #

Patch Set 3 : Fix build for relanding #

Patch Set 4 : Fix chromeos build #

Patch Set 5 : Fix win_aura #

Patch Set 6 : Fix win_aura #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -4 lines) Patch
M chrome/browser/ui/panels/panel.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 2 3 4 5 2 chunks +41 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_view.cc View 1 2 3 5 chunks +67 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jianli
8 years, 4 months ago (2012-08-06 23:03:48 UTC) #1
jennb
lgtm if trybots agree http://codereview.chromium.org/10825210/diff/2001/chrome/browser/ui/panels/panel_view.cc File chrome/browser/ui/panels/panel_view.cc (right): http://codereview.chromium.org/10825210/diff/2001/chrome/browser/ui/panels/panel_view.cc#newcode31 chrome/browser/ui/panels/panel_view.cc:31: struct AcceleratorMapping { Could also ...
8 years, 4 months ago (2012-08-07 00:38:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/10825210/6
8 years, 4 months ago (2012-08-07 20:12:54 UTC) #3
commit-bot: I haz the power
Change committed as 150420
8 years, 4 months ago (2012-08-07 21:35:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/10825210/1008
8 years, 4 months ago (2012-08-08 23:03:23 UTC) #5
commit-bot: I haz the power
Try job failure for 10825210-1008 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-08 23:32:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/10825210/5005
8 years, 4 months ago (2012-08-09 00:52:29 UTC) #7
commit-bot: I haz the power
Try job failure for 10825210-5005 (retry) on linux_rel for step "nacl_integration". It's a second try, ...
8 years, 4 months ago (2012-08-09 02:16:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/10825210/5005
8 years, 4 months ago (2012-08-09 03:05:15 UTC) #9
commit-bot: I haz the power
Change committed as 150725
8 years, 4 months ago (2012-08-09 04:08:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/10825210/8019
8 years, 4 months ago (2012-08-09 21:15:37 UTC) #11
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 22:48:33 UTC) #12
Change committed as 150927

Powered by Google App Engine
This is Rietveld 408576698