Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10825194: Change Deryptor::DecryptStatus and VideoDecoder::DecoderStatus to *::Status. (Closed)

Created:
8 years, 4 months ago by xhwang
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Change Deryptor::DecryptStatus and VideoDecoder::DecoderStatus to *::Status. Previously this was not possible because it conflicts with a macro in x11. This has been fixed by acolwell@. Make this change now to be consistent with DemuxerStream::Status, AudioDecoder::Status, and SourceBufferStream::Status. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150397

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M content/renderer/media/capture_video_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/decryptor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/video_decoder.h View 2 chunks +2 lines, -3 lines 0 comments Download
M media/crypto/aes_decryptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 1 15 chunks +18 lines, -18 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/filters/video_renderer_base.h View 1 1 chunk +1 line, -1 line 0 comments Download
M media/filters/video_renderer_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/media/crypto/proxy_decryptor.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/media/crypto/proxy_decryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/media/crypto/proxy_decryptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
xhwang
Renaming only. PTAL!
8 years, 4 months ago (2012-08-04 00:18:47 UTC) #1
xhwang
On 2012/08/04 00:18:47, xhwang wrote: > Renaming only. PTAL! scherkus@: ping?
8 years, 4 months ago (2012-08-07 16:10:44 UTC) #2
scherkus (not reviewing)
lgtm sorry it slipped off my queue :(
8 years, 4 months ago (2012-08-07 16:46:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/10825194/2002
8 years, 4 months ago (2012-08-07 18:08:25 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 21:04:08 UTC) #5 
Change committed as 150397

Powered by Google App Engine
This is Rietveld 408576698