Issue 10825193: [Chromoting] Extract branding from the signing script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825193: [Chromoting] Extract branding from the signing script. (Closed)

Created:
8 years, 4 months ago by garykac

Modified:
8 years, 4 months ago

Reviewers:
Mark Mentovai, Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[Chromoting] Extract branding from the signing script. With this change, all branding happens to the props file which is read by the signing script. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150006

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -35 lines)			Patch
M	remoting/host/installer/build-installer-archive.py	View		1 chunk	+1 line, -1 line	0 comments	Download
A	remoting/host/installer/mac/do_signing.props	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	remoting/host/installer/mac/do_signing.sh	View	1 2	4 chunks	+57 lines, -34 lines	0 comments	Download
M	remoting/remoting.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/10825193/4003

8 years, 4 months ago (2012-08-04 01:19:53 UTC) #3

Change committed as 150006

Expand Messages | Collapse Messages