Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 10825192: Add debugging flag --simulate-touch-screen-with-mouse. (Closed)

Created:
8 years, 4 months ago by aelias_OOO_until_Jul13
Modified:
8 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Rick Byers, Jeff Timanus, wjmaclean, sadrul, rjkroege
Visibility:
Public.

Description

Add debugging flag --simulate-touch-screen-with-mouse. This flag causes mouse events to be mapped to touch gesture events in RenderWidgetHost: - Hold left mouse button and move: GestureScrollUpdate - Hold right mouse button and move on Y axis: GesturePinchUpdate - Middle mouse button down: GestureTapDown - Middle mouse button up: GestureTap This provides a convenient way to test touch-oriented features with only an ordinary Linux machine. Note that to get pinch gesture support, --enable-threaded-compositing must also be set. BUG=132607 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150274

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed style problems #

Patch Set 3 : Fixed Android trybot failure with float/double conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 2 chunks +93 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
aelias_OOO_until_Jul13
People are having trouble getting the specialized hardware/builds running for touchscreen support, so I whipped ...
8 years, 4 months ago (2012-08-03 22:01:57 UTC) #1
jam
http://codereview.chromium.org/10825192/diff/1/content/browser/renderer_host/render_widget_host_impl.cc File content/browser/renderer_host/render_widget_host_impl.cc (right): http://codereview.chromium.org/10825192/diff/1/content/browser/renderer_host/render_widget_host_impl.cc#newcode758 content/browser/renderer_host/render_widget_host_impl.cc:758: { nit: this function is using webkit style, please ...
8 years, 4 months ago (2012-08-06 18:33:21 UTC) #2
aelias_OOO_until_Jul13
https://chromiumcodereview.appspot.com/10825192/diff/1/content/browser/renderer_host/render_widget_host_impl.cc File content/browser/renderer_host/render_widget_host_impl.cc (right): https://chromiumcodereview.appspot.com/10825192/diff/1/content/browser/renderer_host/render_widget_host_impl.cc#newcode758 content/browser/renderer_host/render_widget_host_impl.cc:758: { Done. By the way, is there a style ...
8 years, 4 months ago (2012-08-06 18:46:30 UTC) #3
jam
lgtm
8 years, 4 months ago (2012-08-06 19:07:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/10825192/3001
8 years, 4 months ago (2012-08-06 19:16:59 UTC) #5
commit-bot: I haz the power
Try job failure for 10825192-3001 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-06 19:33:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/10825192/7003
8 years, 4 months ago (2012-08-06 20:44:55 UTC) #7
commit-bot: I haz the power
Try job failure for 10825192-7003 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 22:20:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/10825192/7003
8 years, 4 months ago (2012-08-07 02:51:16 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 04:41:35 UTC) #10
Change committed as 150274

Powered by Google App Engine
This is Rietveld 408576698