[NaCl SDK] Get nacl_mounts_tests building.

[NaCl SDK] Get nacl_mounts_tests building.

BUG=none
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150893

[noelallen1, 2012-08-09 18:26:57]

LGTM

http://codereview.chromium.org/10825189/diff/18/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/nacl_mounts/kernel_handle.h (right):

http://codereview.chromium.org/10825189/diff/18/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_mounts/kernel_handle.h:34: bool Release() {
return RefObject::Release(); }
I originally had this as bool, then realized I never looked at the return value
of Release.  Do you actually use this value?

[binji, 2012-08-09 19:39:23]

http://codereview.chromium.org/10825189/diff/18/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/nacl_mounts/kernel_handle.h (right):

http://codereview.chromium.org/10825189/diff/18/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_mounts/kernel_handle.h:34: bool Release() {
return RefObject::Release(); }
On 2012/08/09 18:26:57, noelallen1 wrote:
> I originally had this as bool, then realized I never looked at the return
value
> of Release.  Do you actually use this value?

Yes, see my other comment.

http://codereview.chromium.org/10825189/diff/18/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/nacl_mounts_test/mount_test.cc (right):

http://codereview.chromium.org/10825189/diff/18/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_mounts_test/mount_test.cc:33: if
(!node->Release()) {
return value from Release is used here.

[commit-bot: I haz the power, 2012-08-09 20:01:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/10825189/18

[commit-bot: I haz the power, 2012-08-09 20:40:24]

Change committed as 150893