Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: remoting/webapp/client_screen.js

Issue 10825187: Suppress "errors" that aren't really errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added JSCompiler hints. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/client_screen.js
diff --git a/remoting/webapp/client_screen.js b/remoting/webapp/client_screen.js
index 9cdd87e2671b39a33a58bb459ca19a72c512332b..0432a3648263fd295e8c1c2293822ed0c6356fc8 100644
--- a/remoting/webapp/client_screen.js
+++ b/remoting/webapp/client_screen.js
@@ -246,7 +246,7 @@ function onClientStateChange_(oldState, newState) {
} else if (newState == remoting.ClientSession.State.FAILED) {
console.error('Client plugin reported connection failed: ' +
- remoting.clientSession.error);
+ remoting.clientSession.error);
clearPin = true;
if (remoting.clientSession.error ==
remoting.ClientSession.ConnectionError.HOST_IS_OFFLINE) {
@@ -530,6 +530,8 @@ function connectMe2MeWithAccessToken_(token) {
pin, 'spake2_hmac,spake2_plain', remoting.hostId,
/** @type {string} */ (remoting.oauth2.getCachedEmail()),
remoting.ClientSession.Mode.ME2ME, onClientStateChange_);
+ // Don't log errors for cached JIDs.
+ remoting.clientSession.logErrors(!remoting.retryIfOffline);
remoting.clientSession.createPluginAndConnect(
document.getElementById('session-mode'),
token);

Powered by Google App Engine
This is Rietveld 408576698