Issue 10825183: net: disable TLS compression with OpenSSL.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10825183: net: disable TLS compression with OpenSSL. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 1 month ago by agl

Modified:
5 years ago

Reviewers:
joth, wtc, klobag.chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, joth

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	net/socket/ssl_client_socket_openssl.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Trybot results: win_rel win_rel linux_rel linux_rel mac_rel win android linux_clang mac linux_chromeos

Commit queue not available (can’t edit this change).

Total messages: 8 (0 generated)

joth

Lgtm I can't see the linked bug , but guess this is necessary :-)

5 years, 1 month ago (2012-08-03 18:39:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/10825183/1

5 years, 1 month ago (2012-08-03 19:43:17 UTC) #3

indutny

Now, almost every aware person on internet has pulled your change in one's project, it's ...

5 years ago (2012-09-12 19:11:44 UTC) #7

joost

5 years ago (2012-09-13 09:35:31 UTC) #8

The reason is this?:
http://arstechnica.com/security/2012/09/crime-hijacks-https-sessions/