Issue 10825182: Making file names (with icons) clickable in File Manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825182: Making file names (with icons) clickable in File Manager. (Closed)

Created:
8 years, 4 months ago by SeRya

Modified:
8 years, 4 months ago

Reviewers:
Vladislav Kaznacheev, Dmitry Zvorygin

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Making file names (with icons) clickable in File Manager. BUG=138094 TEST=Manual test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149897

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -5 lines)			Patch
	M	chrome/browser/resources/file_manager/css/file_manager.css	View		5 chunks	+18 lines, -2 lines	0 comments	Download
	M	chrome/browser/resources/file_manager/js/file_manager.js	View		4 chunks	+29 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Zvorygin

LGTM. https://chromiumcodereview.appspot.com/10825182/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/10825182/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode2873 chrome/browser/resources/file_manager/js/file_manager.js:2873: if (event.target.parentElement.classList.contains('filename-label') || I don't like this hacky ...

8 years, 4 months ago (2012-08-03 18:03:40 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10825182/1

8 years, 4 months ago (2012-08-03 18:19:25 UTC) #3

Change committed as 149897

Expand Messages | Collapse Messages