Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 10825178: Change EXPECT(!Dart_IsError(...)) to EXPECT_VALID(...) in VM tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/dart_api_impl_test.cc
diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc
index 18416e82fbe03752139373727ab5752e9dffefd8..9be8976ca56a113f12bb7a92c947794e2c962130 100644
--- a/runtime/vm/dart_api_impl_test.cc
+++ b/runtime/vm/dart_api_impl_test.cc
@@ -33,7 +33,7 @@ TEST_CASE(ErrorHandleBasics) {
0,
NULL);
- EXPECT(!Dart_IsError(instance));
+ EXPECT_VALID(instance);
EXPECT(Dart_IsError(error));
EXPECT(Dart_IsError(exception));
@@ -73,7 +73,7 @@ TEST_CASE(ErrorHandleTypes) {
Dart_Handle fatal_error =
Api::NewHandle(isolate, UnwindError::New(fatal_message));
- EXPECT(!Dart_IsError(not_error));
+ EXPECT_VALID(not_error);
EXPECT(Dart_IsError(api_error));
EXPECT(Dart_IsError(exception_error));
EXPECT(Dart_IsError(compile_error));
@@ -4895,7 +4895,7 @@ TEST_CASE(LoadImportScript) {
result = Dart_SetImportMap(import_map);
EXPECT_VALID(result);
result = Dart_LoadScript(url, source);
- EXPECT(!Dart_IsError(result));
+ EXPECT_VALID(result);
}
@@ -6205,7 +6205,7 @@ UNIT_TEST_CASE(IsolateShutdown) {
}
static int64_t GetValue(Dart_Handle arg) {
- EXPECT(!Dart_IsError(arg));
+ EXPECT_VALID(arg);
EXPECT(Dart_IsInteger(arg));
int64_t value;
EXPECT_VALID(Dart_IntegerToInt64(arg, &value));
@@ -6217,7 +6217,7 @@ static void NativeFoo1(Dart_NativeArguments args) {
intptr_t i = Dart_GetNativeArgumentCount(args);
EXPECT_EQ(1, i);
Dart_Handle arg = Dart_GetNativeArgument(args, 0);
- EXPECT(!Dart_IsError(arg));
+ EXPECT_VALID(arg);
Dart_SetReturnValue(args, Dart_NewInteger(1));
Dart_ExitScope();
}

Powered by Google App Engine
This is Rietveld 408576698