Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 10825169: Added check for invalid histogram data, added additional diagnostics to find the source of troubles… (Closed)

Created:
8 years, 4 months ago by zel
Modified:
8 years, 4 months ago
CC:
chromium-reviews, MAD, nkostylev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, Ilya Sherman, davemoore+watch_chromium.org, jar (doing other things)
Visibility:
Public.

Description

Added check for invalid histogram data, added additional diagnostics to find the source of troubles on ChromeOS. BUG=140301 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149797

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/browser/chromeos/external_metrics.cc View 1 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hshi1
LGTM with nit (indentation), thanks! https://chromiumcodereview.appspot.com/10825169/diff/1/chrome/browser/chromeos/external_metrics.cc File chrome/browser/chromeos/external_metrics.cc (right): https://chromiumcodereview.appspot.com/10825169/diff/1/chrome/browser/chromeos/external_metrics.cc#newcode42 chrome/browser/chromeos/external_metrics.cc:42: size_t bucket_count) { nit: ...
8 years, 4 months ago (2012-08-03 02:24:23 UTC) #1
zel
https://chromiumcodereview.appspot.com/10825169/diff/1/chrome/browser/chromeos/external_metrics.cc File chrome/browser/chromeos/external_metrics.cc (right): https://chromiumcodereview.appspot.com/10825169/diff/1/chrome/browser/chromeos/external_metrics.cc#newcode42 chrome/browser/chromeos/external_metrics.cc:42: size_t bucket_count) { On 2012/08/03 02:24:24, hshi1 wrote: > ...
8 years, 4 months ago (2012-08-03 02:29:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10825169/1
8 years, 4 months ago (2012-08-03 02:30:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/10825169/3
8 years, 4 months ago (2012-08-03 03:14:00 UTC) #4
commit-bot: I haz the power
Change committed as 149797
8 years, 4 months ago (2012-08-03 07:18:46 UTC) #5
jar (doing other things)
8 years, 4 months ago (2012-08-24 00:17:01 UTC) #6
jar (doing other things)
8 years, 4 months ago (2012-08-24 00:17:26 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698