Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: runtime/vm/raw_object.h

Issue 10825167: Describe the reserved header bits with their own bit-field definition. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/raw_object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object.h
diff --git a/runtime/vm/raw_object.h b/runtime/vm/raw_object.h
index 23676b493e6c5fb4c9f5a5dac445314440ac5019..eb2f88dc1e26ae3082fc30d80f4dc87999870d21 100644
--- a/runtime/vm/raw_object.h
+++ b/runtime/vm/raw_object.h
@@ -183,10 +183,8 @@ class RawObject {
kMarkBit = 1,
kCanonicalBit = 2,
kFromSnapshotBit = 3,
- kReservedBit10K = 4,
- kReservedBit100K = 5,
- kReservedBit1M = 6,
- kReservedBit10M = 7,
+ kReservedTagBit = 4, // kReservedBit{10K,100K,1M,10M}
+ kReservedTagSize = 4,
kSizeTagBit = 8,
kSizeTagSize = 8,
kClassIdTagBit = kSizeTagBit + kSizeTagSize,
@@ -330,6 +328,10 @@ class RawObject {
class CreatedFromSnapshotTag : public BitField<bool, kFromSnapshotBit, 1> {};
+ class ReservedBits : public BitField<intptr_t,
+ kReservedTagBit,
+ kReservedTagSize> {}; // NOLINT
+
RawObject* ptr() const {
ASSERT(IsHeapObject());
return reinterpret_cast<RawObject*>(
« no previous file with comments | « no previous file | runtime/vm/raw_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698