Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: runtime/vm/raw_object.cc

Issue 10825167: Describe the reserved header bits with their own bit-field definition. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object.cc
diff --git a/runtime/vm/raw_object.cc b/runtime/vm/raw_object.cc
index 2aeaf2b28eff7d04a4e61c979e6d4be0b25c8522..08875861e82d99ef3df4a5a0984d1f547966c7e5 100644
--- a/runtime/vm/raw_object.cc
+++ b/runtime/vm/raw_object.cc
@@ -25,12 +25,8 @@ void RawObject::Validate(Isolate* isolate) const {
}
// Validate that the tags_ field is sensible.
uword tags = ptr()->tags_;
- uword reserved = 0;
- reserved |= (1 << kReservedBit10K);
- reserved |= (1 << kReservedBit100K);
- reserved |= (1 << kReservedBit1M);
- reserved |= (1 << kReservedBit10M);
- if ((tags & reserved) != 0) {
+ intptr_t reserved = ReservedBits::decode(tags);
+ if (reserved != 0) {
FATAL1("Invalid tags field encountered %#lx\n", tags);
}
intptr_t class_id = ClassIdTag::decode(tags);
« no previous file with comments | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698