Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 10825166: Account for some UI changes in the Chrome Endure docs/plus tests. (Closed)

Created:
8 years, 4 months ago by dennis_jeffrey
Modified:
8 years, 4 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh, fdeng1
Visibility:
Public.

Description

Account for some UI changes in the Chrome Endure docs/plus tests. Change 1: fix a problem where the docs test fails when the UI unexpectedly and automatically reloads. The fix is to identify when this happens and invoke some setup code that allows the test scenario to work properly in the event that it does happen. Change 2: modify two xpaths in the plus test to account for UI changes. BUG=None TEST=Verified that both tests run for at least several minutes with these changes. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149751

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M chrome/test/functional/perf_endure.py View 4 chunks +23 lines, -12 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
dennis_jeffrey
8 years, 4 months ago (2012-08-02 23:09:23 UTC) #1
Nirnimesh
https://chromiumcodereview.appspot.com/10825166/diff/1/chrome/test/functional/perf_endure.py File chrome/test/functional/perf_endure.py (right): https://chromiumcodereview.appspot.com/10825166/diff/1/chrome/test/functional/perf_endure.py#newcode978 chrome/test/functional/perf_endure.py:978: sort_button.click() twice?
8 years, 4 months ago (2012-08-02 23:11:34 UTC) #2
dennis_jeffrey
https://chromiumcodereview.appspot.com/10825166/diff/1/chrome/test/functional/perf_endure.py File chrome/test/functional/perf_endure.py (right): https://chromiumcodereview.appspot.com/10825166/diff/1/chrome/test/functional/perf_endure.py#newcode978 chrome/test/functional/perf_endure.py:978: sort_button.click() On 2012/08/02 23:11:34, Nirnimesh wrote: > twice? yes, ...
8 years, 4 months ago (2012-08-02 23:26:55 UTC) #3
Nirnimesh
LGTM
8 years, 4 months ago (2012-08-02 23:56:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dennisjeffrey@chromium.org/10825166/1
8 years, 4 months ago (2012-08-02 23:58:28 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 23:59:57 UTC) #6
Change committed as 149751

Powered by Google App Engine
This is Rietveld 408576698