android_webview/lib/DEPS - Issue 10825155: Build target for Android WebView.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/lib/DEPS

Issue 10825155: Build target for Android WebView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 include_rules = [
	Jói 2012/08/02 15:20:00 Could you add the following to this DEPS file, and Could you add the following to this DEPS file, and any others created under android_webview, to help make sure us Browser Components folks are aware of added dependencies and can help break them ASAP? # Please add joi@ or erikwright@ as reviewers for any changes # to DEPS files under android_webview/. Torne 2012/08/03 10:31:36 Done. Show quoted text On 2012/08/02 15:20:00, Jói wrote: > Could you add the following to this DEPS file, and any others created under > android_webview, to help make sure us Browser Components folks are aware of > added dependencies and can help break them ASAP? > > # Please add joi@ or erikwright@ as reviewers for any changes > # to DEPS files under android_webview/. Done.
	2 "+content/public",

	3

	4 # Temporary until we no longer inherit from ChromeMainDelegate

	5 "!chrome/app/chrome_main_delegate.h"
	Jói 2012/08/02 15:20:00 I believe the plan was for all the temporary depen I believe the plan was for all the temporary dependencies on Chrome to be in android_webview/dll, and none in lib. Did I misunderstand? Torne 2012/08/03 10:31:36 Sorry, I arrived at a different structure separate Show quoted text On 2012/08/02 15:20:00, Jói wrote: > I believe the plan was for all the temporary dependencies on Chrome to be in > android_webview/dll, and none in lib. Did I misunderstand? Sorry, I arrived at a different structure separately, you didn't misunderstand, I just wasn't in that conversation. :) I've discussed the names with joth, and the "dll" vs "lib" names don't seem ideal; it looks like we want to go with the library main code to be in "lib/main" (with "lib" allowing deps on chrome) and the normal webview implementation code to be in "native" and "java" and "test" and so on. I've shuffled the code slightly more in the next version to match, and I've added more comments/explanation to DEPS here, and also add a DEPS in android_webview itself, to make this clearer. Using "lib" for this is briefly confusing to the people who heard the earlier suggestion, but in the long term I think it makes more sense.
	6 ]

OLD	NEW