Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 10825154: Extends IBusContextClient to handle SetSurroundingText. (Closed)

Created:
8 years, 4 months ago by Seigo Nonaka
Modified:
8 years, 4 months ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@surrounding_support
Visibility:
Public.

Description

Extends IBusContextClient to handle SetSurroundingText. BUG=127032 TEST=ran chromeos_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149687

Patch Set 1 : #

Patch Set 2 : Style Fix #

Total comments: 6

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M chromeos/dbus/ibus/ibus_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client_unittest.cc View 3 chunks +45 lines, -0 lines 0 comments Download
M chromeos/dbus/ibus/mock_ibus_input_context_client.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chromeos/dbus/ibus/mock_ibus_input_context_client.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Seigo Nonaka
8 years, 4 months ago (2012-08-02 14:04:17 UTC) #1
satorux1
LGTM with nits http://codereview.chromium.org/10825154/diff/6001/chromeos/dbus/ibus/ibus_input_context_client.cc File chromeos/dbus/ibus/ibus_input_context_client.cc (right): http://codereview.chromium.org/10825154/diff/6001/chromeos/dbus/ibus/ibus_input_context_client.cc#newcode188 chromeos/dbus/ibus/ibus_input_context_client.cc:188: uint32 end_index) OVERRIDE { one parameter ...
8 years, 4 months ago (2012-08-02 16:38:16 UTC) #2
Seigo Nonaka
Thank you for your review. http://codereview.chromium.org/10825154/diff/6001/chromeos/dbus/ibus/ibus_input_context_client.cc File chromeos/dbus/ibus/ibus_input_context_client.cc (right): http://codereview.chromium.org/10825154/diff/6001/chromeos/dbus/ibus/ibus_input_context_client.cc#newcode188 chromeos/dbus/ibus/ibus_input_context_client.cc:188: uint32 end_index) OVERRIDE { ...
8 years, 4 months ago (2012-08-02 17:54:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10825154/7007
8 years, 4 months ago (2012-08-02 18:34:39 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 20:13:59 UTC) #5
Change committed as 149687

Powered by Google App Engine
This is Rietveld 408576698