Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: chrome/browser/bookmarks/bookmark_model_unittest.cc

Issue 10825147: Made BookmarkService::GetBookmarks return both urls and title. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: splited into 2 cls Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_model_unittest.cc
diff --git a/chrome/browser/bookmarks/bookmark_model_unittest.cc b/chrome/browser/bookmarks/bookmark_model_unittest.cc
index 0de5d76f6bb5d6e2cc707f096698793aa8c9813d..236f5a97ca8682108ba663df3899781bbc0f7c6b 100644
--- a/chrome/browser/bookmarks/bookmark_model_unittest.cc
+++ b/chrome/browser/bookmarks/bookmark_model_unittest.cc
@@ -613,13 +613,21 @@ TEST_F(BookmarkModelTest, GetMostRecentlyAddedNodeForURL) {
// Makes sure GetBookmarks removes duplicates.
TEST_F(BookmarkModelTest, GetBookmarksWithDups) {
const GURL url("http://foo.com/0");
- model_.AddURL(model_.bookmark_bar_node(), 0, ASCIIToUTF16("blah"), url);
- model_.AddURL(model_.bookmark_bar_node(), 1, ASCIIToUTF16("blah"), url);
-
- std::vector<GURL> urls;
- model_.GetBookmarks(&urls);
- EXPECT_EQ(1U, urls.size());
- ASSERT_TRUE(urls[0] == url);
+ const string16 title(ASCIIToUTF16("blah"));
+ model_.AddURL(model_.bookmark_bar_node(), 0, title, url);
+ model_.AddURL(model_.bookmark_bar_node(), 1, title, url);
+
+ std::vector<BookmarkService::Bookmark> bookmarks;
+ model_.GetBookmarks(&bookmarks);
+ ASSERT_EQ(1U, bookmarks.size());
+ EXPECT_EQ(url, bookmarks[0].url);
+ EXPECT_EQ(title, bookmarks[0].title);
+
+ model_.AddURL(model_.bookmark_bar_node(), 2, ASCIIToUTF16("Title2"), url);
+ // Only one returned, even titles are different.
+ bookmarks.clear();
+ model_.GetBookmarks(&bookmarks);
+ EXPECT_EQ(1U, bookmarks.size());
}
TEST_F(BookmarkModelTest, HasBookmarks) {

Powered by Google App Engine
This is Rietveld 408576698