Made BookmarkService::GetBookmarks return both urls and title.

- Made BookmarkService::GetBookmarks return both urls and title,
  it still return the unique URLs, not matter what the title is.

BUG=http://b/6696843

TEST=AndroidProviderBackendTest, BookmarkModelTest, BookmarkModelSQLHandlerTest

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150136

[sky, 2012-08-02 16:19:52]

Can you separate these into two patches. First Getbookmarks change,
then other changes.

  -Scott

On Wed, Aug 1, 2012 at 7:17 PM,  <michaelbai@chromium.org> wrote:
> Reviewers: sky,
>
> Description:
> Made manually added bookmark available in android provider.
>
> - Made BookmarkService::GetBookmarks return both urls and title,
>   it still return the unique URLs, not matter what the title is.
> - Added bookmarks that didn't have history into history database during the
> the
> table update, so they are accessable from android provider.
>
> BUG=http://b/6696843
>
>
> Please review this at https://chromiumcodereview.appspot.com/10825147/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M chrome/browser/bookmarks/bookmark_model.h
>   M chrome/browser/bookmarks/bookmark_model.cc
>   M chrome/browser/bookmarks/bookmark_model_unittest.cc
>   M chrome/browser/bookmarks/bookmark_service.h
>   M chrome/browser/history/android/android_provider_backend.h
>   M chrome/browser/history/android/android_provider_backend.cc
>   M chrome/browser/history/android/android_provider_backend_unittest.cc
>   M chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc
>   M chrome/browser/history/history_backend.cc
>
>

[michaelbai, 2012-08-02 17:51:26]

Split into 2 CLs, this is 1st one.

PTAL

[sky, 2012-08-03 16:04:39]

https://chromiumcodereview.appspot.com/10825147/diff/11001/chrome/browser/boo...
File chrome/browser/bookmarks/bookmark_model.h (right):

https://chromiumcodereview.appspot.com/10825147/diff/11001/chrome/browser/boo...
chrome/browser/bookmarks/bookmark_model.h:295: // Returns all the bookmarked
urls and their title.
title -> titles

https://chromiumcodereview.appspot.com/10825147/diff/11001/chrome/browser/boo...
File chrome/browser/bookmarks/bookmark_service.h (right):

https://chromiumcodereview.appspot.com/10825147/diff/11001/chrome/browser/boo...
chrome/browser/bookmarks/bookmark_service.h:20: struct Bookmark {
This name is too generic, how about URLAndTitle.

[michaelbai, 2012-08-03 17:57:49]

PTAL

https://chromiumcodereview.appspot.com/10825147/diff/11001/chrome/browser/boo...
File chrome/browser/bookmarks/bookmark_model.h (right):

https://chromiumcodereview.appspot.com/10825147/diff/11001/chrome/browser/boo...
chrome/browser/bookmarks/bookmark_model.h:295: // Returns all the bookmarked
urls and their title.
On 2012/08/03 16:04:39, sky wrote:
> title -> titles

Done.

https://chromiumcodereview.appspot.com/10825147/diff/11001/chrome/browser/boo...
File chrome/browser/bookmarks/bookmark_service.h (right):

https://chromiumcodereview.appspot.com/10825147/diff/11001/chrome/browser/boo...
chrome/browser/bookmarks/bookmark_service.h:20: struct Bookmark {
I was thinking it might not so generic as it is defined in BookmarkService. 

Changed it to URLAndTitle

On 2012/08/03 16:04:39, sky wrote:
> This name is too generic, how about URLAndTitle.

[sky, 2012-08-03 22:21:17]

LGTM

[commit-bot: I haz the power, 2012-08-03 22:36:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10825147/9004

[commit-bot: I haz the power, 2012-08-03 23:54:14]

Try job failure for 10825147-9004 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-06 04:52:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10825147/9004

[commit-bot: I haz the power, 2012-08-06 05:12:09]

Try job failure for 10825147-9004 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-06 17:09:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10825147/11014

[commit-bot: I haz the power, 2012-08-06 17:25:44]

Try job failure for 10825147-11014 (retry) on win_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-06 17:43:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10825147/17002

[commit-bot: I haz the power, 2012-08-06 18:02:37]

Try job failure for 10825147-17002 (retry) on win_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-06 18:34:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10825147/1026

[commit-bot: I haz the power, 2012-08-06 20:04:19]

Change committed as 150136