Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10825145: Modifying ppapi_untrusted to match new gyp expectations. (Closed)

Created:
8 years, 4 months ago by bradn
Modified:
8 years, 4 months ago
Reviewers:
bbudge, brettw, viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Modifying ppapi_untrusted to match new gyp expectations. default_defines is no longer set in untrusted.gypi Using normal define merging instead. R=bbudge@chromium.org BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149758

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : git try #

Patch Set 4 : git try #

Patch Set 5 : try to be compatible #

Patch Set 6 : deps back and try to be compatible #

Patch Set 7 : drop deps part #

Patch Set 8 : debug clang #

Patch Set 9 : drop include #

Patch Set 10 : new rev #

Patch Set 11 : different rev #

Patch Set 12 : drop deps change #

Patch Set 13 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M ppapi/ppapi_untrusted.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bradn
8 years, 4 months ago (2012-08-02 17:18:20 UTC) #1
bbudge
lgtm
8 years, 4 months ago (2012-08-02 17:51:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/10825145/6010
8 years, 4 months ago (2012-08-02 23:03:42 UTC) #3
commit-bot: I haz the power
Presubmit check for 10825145-6010 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-02 23:03:45 UTC) #4
bradn
Adding some OWNERS in hopes of a review.
8 years, 4 months ago (2012-08-02 23:08:06 UTC) #5
viettrungluu
Rubberstamp LGTM.
8 years, 4 months ago (2012-08-02 23:10:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/10825145/6010
8 years, 4 months ago (2012-08-02 23:10:47 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 01:01:53 UTC) #8 
Change committed as 149758

Powered by Google App Engine
This is Rietveld 408576698