Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 10825143: aura: Fix a couple of drag drop issues: (Closed)

Created:
8 years, 4 months ago by varunjain
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

aura: Fix a couple of drag drop issues: 1. Only DragDropController should be allowed to set the cursor while a drag-drop session is in progress. 2. For some wierd reason I was cancelling drag-drop on MOUSE_EXITED event. That is clearly wrong. BUG=138694 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149670

Patch Set 1 #

Patch Set 2 : patch #

Total comments: 2

Patch Set 3 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M ash/drag_drop/drag_drop_controller.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 2 6 chunks +8 lines, -3 lines 0 comments Download
M ui/aura/client/drag_drop_client.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
varunjain
8 years, 4 months ago (2012-08-01 23:21:46 UTC) #1
sky
https://chromiumcodereview.appspot.com/10825143/diff/1002/ash/drag_drop/drag_drop_controller.cc File ash/drag_drop/drag_drop_controller.cc (right): https://chromiumcodereview.appspot.com/10825143/diff/1002/ash/drag_drop/drag_drop_controller.cc#newcode37 ash/drag_drop/drag_drop_controller.cc:37: ash::Shell::GetInstance()->cursor_manager()->UnlockCursor(); Unlock/Lock decrement/increment a count. So, it's entirely possible ...
8 years, 4 months ago (2012-08-02 16:26:41 UTC) #2
sky
Also, I'm not sure you always want to force it. For example, if the drag ...
8 years, 4 months ago (2012-08-02 17:27:36 UTC) #3
varunjain
https://chromiumcodereview.appspot.com/10825143/diff/1002/ash/drag_drop/drag_drop_controller.cc File ash/drag_drop/drag_drop_controller.cc (right): https://chromiumcodereview.appspot.com/10825143/diff/1002/ash/drag_drop/drag_drop_controller.cc#newcode37 ash/drag_drop/drag_drop_controller.cc:37: ash::Shell::GetInstance()->cursor_manager()->UnlockCursor(); On 2012/08/02 16:26:42, sky wrote: > Unlock/Lock decrement/increment ...
8 years, 4 months ago (2012-08-02 17:29:52 UTC) #4
sky
LGTM
8 years, 4 months ago (2012-08-02 17:38:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10825143/6001
8 years, 4 months ago (2012-08-02 17:41:02 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 19:19:59 UTC) #7
Change committed as 149670

Powered by Google App Engine
This is Rietveld 408576698