Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: utils/tests/pub/pub_test.dart

Issue 10825142: Actually enable the pub update tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Re-upload Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/pub_test.dart
diff --git a/utils/tests/pub/pub_test.dart b/utils/tests/pub/pub_test.dart
index 1955e4f007ba98e2407ba3bd899bfc7c00b329f3..ca65c1d9c7b077e1f082b4b83f7ca190d0e00099 100644
--- a/utils/tests/pub/pub_test.dart
+++ b/utils/tests/pub/pub_test.dart
@@ -59,6 +59,7 @@ main() {
group('pub list', listCommand);
group('pub install', installCommand);
+ group('pub update', updateCommand);
group('pub version', versionCommand);
}
@@ -887,7 +888,7 @@ dependencies:
foo:
git: ../foo.git
bar:
- git: ../foo.git
+ git: ../bar.git
''')
]).scheduleCreate();
@@ -944,7 +945,7 @@ dependencies:
foo:
git: ../foo.git
bar:
- git: ../foo.git
+ git: ../bar.git
''')
]).scheduleCreate();
@@ -968,7 +969,7 @@ dependencies:
file('bar.dart', 'main() => "bar 2";')
]).scheduleCommit();
- schedulePub(args: ['update foo'],
+ schedulePub(args: ['update', 'foo'],
output: const RegExp(@"Dependencies updated!$"));
dir(packagesPath, [
@@ -983,7 +984,8 @@ dependencies:
run();
});
- test("updates one locked Git package's dependencies", () {
+ test("doesn't update one locked Git package's dependencies if it's not "
+ "necessary", () {
ensureGit();
git('foo.git', [
@@ -999,26 +1001,11 @@ dependencies:
file('foo-dep.dart', 'main() => "foo-dep";')
]).scheduleCreate();
- git('bar.git', [
- file('bar.dart', 'main() => "bar";'),
- file('pubspec.yaml', '''
-dependencies:
- bar-dep:
- git: ../bar-dep.git
-''')
- ]).scheduleCreate();
-
- git('bar-dep.git', [
- file('bar-dep.dart', 'main() => "bar-dep";')
- ]).scheduleCreate();
-
dir(appPath, [
file('pubspec.yaml', '''
dependencies:
foo:
git: ../foo.git
- bar:
- git: ../foo.git
''')
]).scheduleCreate();
@@ -1036,34 +1023,28 @@ dependencies:
]),
dir('foo-dep', [
file('foo-dep.dart', 'main() => "foo-dep";')
- ]),
- dir('bar', [
- file('bar.dart', 'main() => "bar";'),
- file('pubspec.yaml', '''
-dependencies:
- bar-dep:
- git: ../bar-dep.git
-''')
- ]),
- dir('bar-dep', [
- file('bar-dep.dart', 'main() => "bar-dep";')
])
]).scheduleValidate();
+ git('foo.git', [
+ file('foo.dart', 'main() => "foo 2";'),
+ file('pubspec.yaml', '''
+dependencies:
+ foo-dep:
+ git: ../foo-dep.git
+''')
+ ]).scheduleCreate();
+
git('foo-dep.git', [
file('foo-dep.dart', 'main() => "foo-dep 2";')
]).scheduleCommit();
- git('bar-dep.git', [
- file('bar-dep.dart', 'main() => "bar-dep 2";')
- ]).scheduleCommit();
-
- schedulePub(args: ['update foo'],
+ schedulePub(args: ['update', 'foo'],
output: const RegExp(@"Dependencies updated!$"));
dir(packagesPath, [
dir('foo', [
- file('foo.dart', 'main() => "foo";'),
+ file('foo.dart', 'main() => "foo 2";'),
file('pubspec.yaml', '''
dependencies:
foo-dep:
@@ -1071,18 +1052,88 @@ dependencies:
''')
]),
dir('foo-dep', [
- file('foo-dep.dart', 'main() => "foo-dep 2";')
+ file('foo-dep.dart', 'main() => "foo-dep";')
]),
- dir('bar', [
- file('bar.dart', 'main() => "bar";'),
+ ]).scheduleValidate();
+
+ run();
+ });
+
+ test("updates one locked pub server package's dependencies if it's "
+ "necessary", () {
+ servePackages("localhost", 3123, [
+ '''
+name: foo
+version: 1.0.0
+dependencies:
+ foo-dep:
+ repo:
+ name: foo-dep
+ url: http://localhost:3123
+''',
+ '{name: foo-dep, version: 1.0.0}'
+ ]);
+
+ dir(appPath, [
+ file('pubspec.yaml', '''
+dependencies:
+ foo:
+ repo:
+ name: foo
+ url: http://localhost:3123
+''')
+ ]).scheduleCreate();
+
+ schedulePub(args: ['install'],
+ output: const RegExp(@"Dependencies installed!$"));
+
+ dir(packagesPath, [
+ dir('foo', [
+ file('foo.dart', 'main() => print("foo 1.0.0");'),
file('pubspec.yaml', '''
+name: foo
+version: 1.0.0
dependencies:
- bar-dep:
- git: ../bar-dep.git
+ foo-dep:
+ repo:
+ name: foo-dep
+ url: http://localhost:3123
''')
]),
- dir('bar-dep', [
- file('bar-dep.dart', 'main() => "bar-dep";')
+ dir('foo-dep', [
+ file('foo-dep.dart', 'main() => print("foo-dep 1.0.0");')
+ ])
+ ]).scheduleValidate();
+
+ servePackages("localhost", 3123, [
+ '''
+name: foo
+version: 2.0.0
+dependencies:
+ foo-dep:
+ repo: {name: foo-dep, url: http://localhost:3123}
+ version: ">1.0.0"
+''',
+ '{name: foo-dep, version: 2.0.0}'
+ ]);
+
+ schedulePub(args: ['update', 'foo'],
+ output: const RegExp(@"Dependencies updated!$"));
+
+ dir(packagesPath, [
+ dir('foo', [
+ file('foo.dart', 'main() => print("foo 2.0.0");'),
+ file('pubspec.yaml', '''
+name: foo
+version: 2.0.0
+dependencies:
+ foo-dep:
+ repo: {name: foo-dep, url: http://localhost:3123}
+ version: ">1.0.0"
+''')
+ ]),
+ dir('foo-dep', [
+ file('foo-dep.dart', 'main() => print("foo-dep 2.0.0");')
])
]).scheduleValidate();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698