Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 10825141: Keep CrOS OOBE user image grid from stealing focus from the OK button (Closed)

Created:
8 years, 4 months ago by dmazzoni
Modified:
8 years, 4 months ago
Reviewers:
Ivan Korotkov
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, satorux1
Visibility:
Public.

Description

Keep CrOS OOBE user image grid from stealing focus from the OK button BUG=140108 TBR=nkostylev Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/chromeos/user_images_grid.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dmazzoni
8 years, 4 months ago (2012-08-01 22:14:40 UTC) #1
Ivan Korotkov
lgtm
8 years, 4 months ago (2012-08-01 22:53:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/10825141/1
8 years, 4 months ago (2012-08-01 22:54:20 UTC) #3
commit-bot: I haz the power
Presubmit check for 10825141-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-01 22:54:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/10825141/1
8 years, 4 months ago (2012-08-02 16:21:46 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 17:51:40 UTC) #6
Change committed as 149652

Powered by Google App Engine
This is Rietveld 408576698