utils/archive/reader.c - Issue 10825139: Free the C memory for ArchiveInputStream when the stream is garbage collected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/archive/reader.c

Issue 10825139: Free the C memory for ArchiveInputStream when the stream is garbage collected. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix a renamed function Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: utils/archive/reader.c

diff --git a/utils/archive/reader.c b/utils/archive/reader.c

index 95eae49a1a4c830324c71741b7aef93ab1ab2d5c..be768b66ca689d80d64b3abbdfec7f966b4846f4 100644

--- a/utils/archive/reader.c

+++ b/utils/archive/reader.c

@@ -341,7 +341,5 @@ void archiveReadClose(Dart_Port p, struct archive* a) {

}

void archiveReadFree(Dart_Port p, struct archive* a) {

- // TODO(nweiz): Should we attach a finalizer to the Dart object that calls

- // this automatically?

checkResult(p, a, archive_read_free(a));

}

« utils/archive/input_stream.dart ('K') | « utils/archive/input_stream.dart ('k') | utils/archive/utils.dart » ('j') | no next file with comments »