Associate keyboard overlay labels with the controls they label.

Associate keyboard overlay labels with the controls they label.

BUG=140066
TEST=Enable spoken feedback, explore Keyboard settings. It's confusing since by default the label is the same as the value, but at least it's accessible.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149512

[James Hawkins, 2012-08-01 20:07:27]

LGTM with nit.

http://codereview.chromium.org/10825136/diff/1/chrome/browser/resources/optio...
File chrome/browser/resources/options2/chromeos/keyboard_overlay.html (right):

http://codereview.chromium.org/10825136/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options2/chromeos/keyboard_overlay.html:9:
i18n-content="xkbRemapSearchKeyToContent">
nit: Not entirely sure, but it looks like this is indented one space too many
(should be 4 spaces).

[dmazzoni, 2012-08-01 20:23:05]

http://codereview.chromium.org/10825136/diff/1/chrome/browser/resources/optio...
File chrome/browser/resources/options2/chromeos/keyboard_overlay.html (right):

http://codereview.chromium.org/10825136/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options2/chromeos/keyboard_overlay.html:9:
i18n-content="xkbRemapSearchKeyToContent">
On 2012/08/01 20:07:27, James Hawkins wrote:
> nit: Not entirely sure, but it looks like this is indented one space too many
> (should be 4 spaces).

It looks like it was a little inconsistent elsewhere in the file. I fixed it
throughout.

[commit-bot: I haz the power, 2012-08-01 20:23:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/10825136/5001

[James Hawkins, 2012-08-01 20:44:51]

http://codereview.chromium.org/10825136/diff/1/chrome/browser/resources/optio...
File chrome/browser/resources/options2/chromeos/keyboard_overlay.html (right):

http://codereview.chromium.org/10825136/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options2/chromeos/keyboard_overlay.html:9:
i18n-content="xkbRemapSearchKeyToContent">
On 2012/08/01 20:23:05, Dominic Mazzoni wrote:
> On 2012/08/01 20:07:27, James Hawkins wrote:
> > nit: Not entirely sure, but it looks like this is indented one space too
many
> > (should be 4 spaces).
> 
> It looks like it was a little inconsistent elsewhere in the file. I fixed it
> throughout.

Thanks!

[commit-bot: I haz the power, 2012-08-01 22:20:01]

Change committed as 149512