Issue 10825134: Start the process of making Autofill into a Browser Component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825134: Start the process of making Autofill into a Browser Component. (Closed)

Created:
8 years, 4 months ago by Jói

Modified:
8 years, 4 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, dhollowa+watch_chromium.org, browser-components-watch_chromium.org, Ilya Sherman, dyu1, browser-components-dev_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Start the process of making Autofill into a Browser Component. This means, add the intended DEPS rules for a Browser Component (depend on nothing within chrome/browser outside the component except chrome/browser/api) and add a temporary owner for pure refactoring changes so that such changes can be done more quickly. Larger changes (that affect functionality or interfaces in non-refactoring ways) will still be sent to a proper OWNER. With the new DEPS, a presubmit check will warn developers that add new temporarily-allowed (the files designated with a "!" rule in the DEPS file). See http://www.chromium.org/developers/design-documents/browser-components BUG=140037 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149490

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -0 lines)			Patch
	M	chrome/browser/autofill/DEPS	View		1 chunk	+46 lines, -0 lines	0 comments	Download
	M	chrome/browser/autofill/OWNERS	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/10825134/1

8 years, 4 months ago (2012-08-01 19:26:12 UTC) #3

Change committed as 149490

Expand Messages | Collapse Messages