Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: content/renderer/speech_recognition_dispatcher.cc

Issue 10825133: Speech recognition: fire the speechstart/speechend events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/speech_recognition_dispatcher.cc
diff --git a/content/renderer/speech_recognition_dispatcher.cc b/content/renderer/speech_recognition_dispatcher.cc
index ad1610c3ccf90d0214a7ba1b6c5e5452dfd74a6d..6cee231134fd38c0d0b385f9f51d732b0c6e18cb 100644
--- a/content/renderer/speech_recognition_dispatcher.cc
+++ b/content/renderer/speech_recognition_dispatcher.cc
@@ -111,9 +111,11 @@ void SpeechRecognitionDispatcher::OnAudioStarted(int request_id) {
void SpeechRecognitionDispatcher::OnSoundStarted(int request_id) {
recognizer_client_->didStartSound(GetHandleFromID(request_id));
darin (slow to review) 2012/08/02 06:18:33 I don't understand why we need two function calls
+ recognizer_client_->didStartSpeech(GetHandleFromID(request_id));
}
void SpeechRecognitionDispatcher::OnSoundEnded(int request_id) {
+ recognizer_client_->didEndSpeech(GetHandleFromID(request_id));
darin (slow to review) 2012/08/02 06:18:33 Ditto.
recognizer_client_->didEndSound(GetHandleFromID(request_id));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698