Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 10825131: Android: move various gyp defines out of envsetup. (Closed)

Created:
8 years, 4 months ago by Torne
Modified:
8 years, 4 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Visibility:
Public.

Description

Android: move various gyp defines out of envsetup. These gyp defines are set unconditionally in envsetup, which means they are not in fact part of the "environment" but just the defaults for the Android build. Move them into common.gypi instead to make this clear. Several of them were already the correct setting and can simply be removed. The makefiles generated by gyp are identical before and after this change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M build/android/envsetup_functions.sh View 1 chunk +2 lines, -13 lines 0 comments Download
M build/common.gypi View 4 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Torne
8 years, 4 months ago (2012-08-01 10:59:40 UTC) #1
Yaron
lgtm
8 years, 4 months ago (2012-08-01 17:51:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/10825131/1
8 years, 4 months ago (2012-08-02 09:50:41 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 11:04:00 UTC) #4
Change committed as 149609

Powered by Google App Engine
This is Rietveld 408576698