chrome/browser/extensions/api/downloads/downloads_api_unittest.cc - Issue 10825127: Valgrind: Clean up leaks in callers to extension_function_test_utils::RunFunction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

Issue 10825127: Valgrind: Clean up leaks in callers to extension_function_test_utils::RunFunction. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/browsing_data/browsing_data_test.cc ('k') | chrome/browser/extensions/api/socket/socket_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

===================================================================

--- chrome/browser/extensions/api/downloads/downloads_api_unittest.cc (revision 149361)

+++ chrome/browser/extensions/api/downloads/downloads_api_unittest.cc (working copy)

@@ -479,6 +479,7 @@

base::Value* RunFunctionAndReturnResult(UIThreadExtensionFunction* function,

const std::string& args) {

+ scoped_refptr<UIThreadExtensionFunction> delete_function(function);

SetUpExtensionFunction(function);

return extension_function_test_utils::RunFunctionAndReturnSingleResult(

function, args, browser(), GetFlags());

@@ -486,6 +487,7 @@

std::string RunFunctionAndReturnError(UIThreadExtensionFunction* function,

const std::string& args) {

+ scoped_refptr<UIThreadExtensionFunction> delete_function(function);

SetUpExtensionFunction(function);

return extension_function_test_utils::RunFunctionAndReturnError(

function, args, browser(), GetFlags());