Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 10825124: Replace --explicit-config option in me2me_virtual_host.py with --silent. (Closed)

Created:
8 years, 4 months ago by Sergey Ulanov
Modified:
8 years, 4 months ago
Reviewers:
Lambros
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Replace --explicit-config option in me2me_virtual_host.py with --silent. BUG=120950 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149504

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -39 lines) Patch
M remoting/host/plugin/daemon_controller_linux.cc View 2 chunks +23 lines, -8 lines 0 comments Download
M remoting/tools/me2me_virtual_host.py View 1 2 5 chunks +52 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
8 years, 4 months ago (2012-08-01 00:53:58 UTC) #1
Lambros
lgtm, assuming the comment/TODO will eventually be fixed :) http://codereview.chromium.org/10825124/diff/4/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): http://codereview.chromium.org/10825124/diff/4/remoting/tools/me2me_virtual_host.py#newcode701 remoting/tools/me2me_virtual_host.py:701: ...
8 years, 4 months ago (2012-08-01 18:30:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10825124/8001
8 years, 4 months ago (2012-08-01 20:18:10 UTC) #3
Sergey Ulanov
http://codereview.chromium.org/10825124/diff/4/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): http://codereview.chromium.org/10825124/diff/4/remoting/tools/me2me_virtual_host.py#newcode701 remoting/tools/me2me_virtual_host.py:701: On 2012/08/01 18:30:57, Lambros wrote: > Good TODO. As ...
8 years, 4 months ago (2012-08-01 20:20:53 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 22:00:26 UTC) #5
Change committed as 149504

Powered by Google App Engine
This is Rietveld 408576698