Issue 10825123: libmtp: Do not build and install bits we don't need - udev utilities and examples.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825123: libmtp: Do not build and install bits we don't need - udev utilities and examples. (Closed)

Created:
8 years, 4 months ago by Lei Zhang

Modified:
8 years, 4 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/deps/third_party/libmtp/

Visibility:
Public.

More Reviews

Description

libmtp: Do not build and install bits we don't need - udev utilities and examples. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149328

Patch Set 1 #

Total comments: 3

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+648 lines, -300 lines)			Patch
M	Makefile.am	View	2 chunks	+15 lines, -15 lines	3 comments	Download
M	Makefile.in	View	8 chunks	+25 lines, -43 lines	0 comments	Download
A	patches/09_do_not_build_udev_and_examples.patch	View	1 chunk	+573 lines, -0 lines	0 comments	Download
M	util/Makefile.am	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	util/Makefile.in	View	10 chunks	+27 lines, -234 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

For CrOS, I want to minimize the amount of stuff we install when we build. ...

8 years, 4 months ago (2012-08-01 00:01:55 UTC) #1

vandebo (ex-Chrome)

LGTM https://chromiumcodereview.appspot.com/10825123/diff/1/Makefile.am File Makefile.am (right): https://chromiumcodereview.appspot.com/10825123/diff/1/Makefile.am#newcode1 Makefile.am:1: SUBDIRS=src util doc kill doc too?

8 years, 4 months ago (2012-08-01 00:09:44 UTC) #2

Lei Zhang

8 years, 4 months ago (2012-08-01 00:12:57 UTC) #3

https://chromiumcodereview.appspot.com/10825123/diff/1/Makefile.am
File Makefile.am (right):

https://chromiumcodereview.appspot.com/10825123/diff/1/Makefile.am#newcode1
Makefile.am:1: SUBDIRS=src util doc
On 2012/08/01 00:09:44, vandebo wrote:
> kill doc too?

The ebuild knows how to disable docs. Plus docs is off by default.

Expand Messages | Collapse Messages