Remove the need to have separate config for authentication.

Remove the need to have separate config for authentication.

Previously host was opening two separate configs, but that doesn't seem
to be very useful. With that change the host still supports --auth-config
option, but it no longer requires auth config and doesn't try to open 
auth.json by default.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149453

[alexeypa (please no reviews), 2012-07-31 23:47:11]

A drive by:

src/remoting/host/installer/chromoting.wxs uses "--auth-config" because of the
sole reason - the me2me host required it. This parameter can be removed now.

[Sergey Ulanov, 2012-08-01 00:27:12]

On 2012/07/31 23:47:11, alexeypa wrote:
> A drive by:
> 
> src/remoting/host/installer/chromoting.wxs uses "--auth-config" because of the
> sole reason - the me2me host required it. This parameter can be removed now.

Done. Also removed that flag from the mac start script and added it in
me2me_virtual_host.py

[Lambros, 2012-08-01 01:12:48]

lgtm with comments

http://codereview.chromium.org/10825121/diff/8001/remoting/host/composite_hos...
File remoting/host/composite_host_config.h (right):

http://codereview.chromium.org/10825121/diff/8001/remoting/host/composite_hos...
remoting/host/composite_host_config.h:37: std::vector<HostConfig*> configs_;
Optional: Use ScopedVector here?

http://codereview.chromium.org/10825121/diff/8001/remoting/host/remoting_me2m...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/10825121/diff/8001/remoting/host/remoting_me2m...
remoting/host/remoting_me2me_host.cc:251: // Read Host config from disk,
returning true if successful.
Remove "from disk" from this comment? Looks like the actual disk-reading has
been moved out of here into InitWithCommandLine().

[Sergey Ulanov, 2012-08-01 01:19:11]

http://codereview.chromium.org/10825121/diff/8001/remoting/host/composite_hos...
File remoting/host/composite_host_config.h (right):

http://codereview.chromium.org/10825121/diff/8001/remoting/host/composite_hos...
remoting/host/composite_host_config.h:37: std::vector<HostConfig*> configs_;
On 2012/08/01 01:12:48, Lambros wrote:
> Optional: Use ScopedVector here?

Done.

http://codereview.chromium.org/10825121/diff/8001/remoting/host/remoting_me2m...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/10825121/diff/8001/remoting/host/remoting_me2m...
remoting/host/remoting_me2me_host.cc:251: // Read Host config from disk,
returning true if successful.
On 2012/08/01 01:12:48, Lambros wrote:
> Remove "from disk" from this comment? Looks like the actual disk-reading has
> been moved out of here into InitWithCommandLine().

Done.

[commit-bot: I haz the power, 2012-08-01 01:19:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10825121/8002

[commit-bot: I haz the power, 2012-08-01 01:19:50]

Failed to apply patch for remoting/host/installer/chromoting.wxs:
While running patch -p1 --forward --force;
patching file remoting/host/installer/chromoting.wxs
Hunk #1 FAILED at 133.
1 out of 1 hunk FAILED -- saving rejects to file
remoting/host/installer/chromoting.wxs.rej

[commit-bot: I haz the power, 2012-08-01 01:23:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10825121/3002

[commit-bot: I haz the power, 2012-08-01 02:16:51]

Try job failure for 10825121-3002 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-08-01 17:30:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10825121/6002

[commit-bot: I haz the power, 2012-08-01 18:55:39]

Change committed as 149453