net-internals: Display time log dump was created at end of printed logs

net-internals:  When viewing a loaded log, display time
how long it's been since idle sources have logged their
most recent event.

BUG=139830
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149341

[mmenke, 2012-07-31 20:45:41]

http://codereview.chromium.org/10825116/diff/5002/chrome/browser/resources/ne...
File chrome/browser/resources/net_internals/log_view_painter.js (right):

http://codereview.chromium.org/10825116/diff/5002/chrome/browser/resources/ne...
chrome/browser/resources/net_internals/log_view_painter.js:96: function
addRowWithTime(tablePrinter, eventTime, startTime) {
Could move this over to ParameterOutputter (writeLineWithTime), and have it
completely manage the TablePrinter, but not sure we get a whole lot from that,
except moving all knowledge of the magic number "5" into  the
ParameterOutputter, which would need to be renamed.

[eroman, 2012-07-31 21:03:09]

Have you considered changing the dt=? to something like dt=729+ ? I think it
would be useful to see some of the deltas implicitly closed at the log creation
time.

[mmenke, 2012-07-31 21:41:53]

On 2012/07/31 21:03:09, eroman wrote:
> Have you considered changing the dt=? to something like dt=729+ ? I think it
> would be useful to see some of the deltas implicitly closed at the log
creation
> time.

Done.

Actually, since I find subtracting st entries faster than looking at the dt
entries to the right, I hadn't considered it, but sounds reasonable, for those
with particularly limber necks, or particularly bad at subtraction.  :)

[eroman, 2012-07-31 21:53:43]

LGTM!

http://codereview.chromium.org/10825116/diff/1004/chrome/test/data/webui/net_...
File chrome/test/data/webui/net_internals/log_view_painter.js (right):

http://codereview.chromium.org/10825116/diff/1004/chrome/test/data/webui/net_...
chrome/test/data/webui/net_internals/log_view_painter.js:816:
testCase.expectedText.replace('[dt=?]', '[dt=789+]') + '\n' +
optional: I think it would be more readable to just duplicate the whole thing.

[mmenke, 2012-07-31 22:53:16]

Thanks for the feedback.

http://codereview.chromium.org/10825116/diff/1004/chrome/test/data/webui/net_...
File chrome/test/data/webui/net_internals/log_view_painter.js (right):

http://codereview.chromium.org/10825116/diff/1004/chrome/test/data/webui/net_...
chrome/test/data/webui/net_internals/log_view_painter.js:816:
testCase.expectedText.replace('[dt=?]', '[dt=789+]') + '\n' +
On 2012/07/31 21:53:43, eroman wrote:
> optional: I think it would be more readable to just duplicate the whole thing.

Done.

[commit-bot: I haz the power, 2012-07-31 23:27:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/10825116/12001

[commit-bot: I haz the power, 2012-08-01 01:03:51]

Change committed as 149341