Clean up FullscreenController.

Clean up FullscreenController.

This change does three things:
* Removes RefCoununted from the class. There's no visible reason for it to be.
* Changes the constructor to only take one param, as the other two params can
  be derived from Browser.
* Re-orders the methods in a logical way, and makes the implementation match
  the interface order.

BUG=114373
TEST=No behavior changes.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149484

[scheib, 2012-08-01 17:33:27]

lgtm

https://chromiumcodereview.appspot.com/10825115/diff/10002/chrome/browser/ui/...
File chrome/browser/ui/fullscreen/fullscreen_controller.h (right):

https://chromiumcodereview.appspot.com/10825115/diff/10002/chrome/browser/ui/...
chrome/browser/ui/fullscreen/fullscreen_controller.h:139: // TODO(koz): Change
|for_tab| to an enum.
I think we can drop this comment, koz is not going to work on this and the need
is too small to warrant a TODO.

[Robert Sesek, 2012-08-01 18:36:38]

Thanks!

https://chromiumcodereview.appspot.com/10825115/diff/10002/chrome/browser/ui/...
File chrome/browser/ui/fullscreen/fullscreen_controller.h (right):

https://chromiumcodereview.appspot.com/10825115/diff/10002/chrome/browser/ui/...
chrome/browser/ui/fullscreen/fullscreen_controller.h:139: // TODO(koz): Change
|for_tab| to an enum.
On 2012/08/01 17:33:27, scheib wrote:
> I think we can drop this comment, koz is not going to work on this and the
need
> is too small to warrant a TODO.

I'll remove it when I do more cleanup.

[commit-bot: I haz the power, 2012-08-01 18:36:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/10825115/10002

[commit-bot: I haz the power, 2012-08-01 18:36:57]

Presubmit check for 10825115-10002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui
    chrome/browser/ui/fullscreen

[Robert Sesek, 2012-08-01 18:40:10]

+ben for OWNERS

[Ben Goodger (Google), 2012-08-01 19:07:51]

nice cleanup. lgtm.

[commit-bot: I haz the power, 2012-08-01 19:09:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/10825115/10002

[commit-bot: I haz the power, 2012-08-01 20:32:35]

Change committed as 149484