Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 10825111: Repack separate 100 / 200 / touch_100 / touch_200 files into single pak files. (Closed)

Created:
8 years, 4 months ago by flackr
Modified:
8 years, 4 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pam+watch_chromium.org, benrg
Visibility:
Public.

Description

Repack separate 100 / 200 / touch_100 / touch_200 files into single pak files. BUG=139803 TEST=Chrome runs with ui and theme resources correctly loaded. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150411

Patch Set 1 #

Total comments: 7

Patch Set 2 : Merge with master #

Patch Set 3 : Merge with master and only include hidpi on enable_hidpi. #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -167 lines) Patch
M build/android/pylib/test_package.py View 1 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
A chrome/chrome_repack_chrome_100_percent.gypi View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/chrome_repack_chrome_200_percent.gypi View 1 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/chrome_repack_chrome_touch_100_percent.gypi View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/chrome_repack_chrome_touch_200_percent.gypi View 1 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 2 4 chunks +57 lines, -49 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/tools/build/chromeos/FILES.cfg View 1 2 chunks +5 lines, -10 lines 0 comments Download
M chrome/tools/build/linux/FILES.cfg View 1 2 2 chunks +5 lines, -10 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 2 chunks +17 lines, -34 lines 0 comments Download
M ui/base/resource/resource_bundle_android.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M ui/base/resource/resource_bundle_aurax11.cc View 1 1 chunk +4 lines, -22 lines 0 comments Download
M ui/base/resource/resource_bundle_gtk.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ui/base/resource/resource_bundle_mac.mm View 1 2 chunks +2 lines, -6 lines 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 1 1 chunk +3 lines, -12 lines 0 comments Download
M ui/test/test_suite.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
flackr
Can you take a preliminary look? Plus you can let me know if this should ...
8 years, 4 months ago (2012-07-31 18:41:14 UTC) #1
Rick Byers
lgtm https://chromiumcodereview.appspot.com/10825111/diff/1/chrome/chrome_repack_chrome_100_percent.gypi File chrome/chrome_repack_chrome_100_percent.gypi (right): https://chromiumcodereview.appspot.com/10825111/diff/1/chrome/chrome_repack_chrome_100_percent.gypi#newcode1 chrome/chrome_repack_chrome_100_percent.gypi:1: # Copyright (c) 2012 The Chromium Authors. All ...
8 years, 4 months ago (2012-07-31 19:38:17 UTC) #2
Rick Byers
On 2012/07/31 18:41:14, flackr wrote: > Can you take a preliminary look? Plus you can ...
8 years, 4 months ago (2012-07-31 19:43:40 UTC) #3
flackr
https://chromiumcodereview.appspot.com/10825111/diff/1/chrome/chrome_repack_chrome_100_percent.gypi File chrome/chrome_repack_chrome_100_percent.gypi (right): https://chromiumcodereview.appspot.com/10825111/diff/1/chrome/chrome_repack_chrome_100_percent.gypi#newcode1 chrome/chrome_repack_chrome_100_percent.gypi:1: # Copyright (c) 2012 The Chromium Authors. All rights ...
8 years, 4 months ago (2012-07-31 19:48:21 UTC) #4
flackr
Nico, Sailesh, can you review / gives owners approval for the changes to chrome/ and ...
8 years, 4 months ago (2012-07-31 20:07:45 UTC) #5
sail
lgtm
8 years, 4 months ago (2012-07-31 20:11:16 UTC) #6
Rick Byers
On 2012/07/31 19:48:21, flackr wrote: > https://chromiumcodereview.appspot.com/10825111/diff/1/chrome/chrome_repack_chrome_100_percent.gypi > File chrome/chrome_repack_chrome_100_percent.gypi (right): > > https://chromiumcodereview.appspot.com/10825111/diff/1/chrome/chrome_repack_chrome_100_percent.gypi#newcode1 > ...
8 years, 4 months ago (2012-07-31 20:15:18 UTC) #7
Josh Horwich
Just a drive-by question/concern about removing "or chromeos=1" clause in including 200% resources. If this ...
8 years, 4 months ago (2012-08-01 23:47:58 UTC) #8
Rick Byers
https://chromiumcodereview.appspot.com/10825111/diff/1/chrome/chrome_resources.gyp File chrome/chrome_resources.gyp (right): https://chromiumcodereview.appspot.com/10825111/diff/1/chrome/chrome_resources.gyp#newcode350 chrome/chrome_resources.gyp:350: ['enable_hidpi == 1 or chromeos == 1', { On ...
8 years, 4 months ago (2012-08-02 00:30:46 UTC) #9
flackr
https://chromiumcodereview.appspot.com/10825111/diff/1/chrome/chrome_resources.gyp File chrome/chrome_resources.gyp (right): https://chromiumcodereview.appspot.com/10825111/diff/1/chrome/chrome_resources.gyp#newcode350 chrome/chrome_resources.gyp:350: ['enable_hidpi == 1 or chromeos == 1', { On ...
8 years, 4 months ago (2012-08-07 13:51:59 UTC) #10
flackr
Scott, can you take a look? Thanks!
8 years, 4 months ago (2012-08-07 13:57:00 UTC) #11
sky
LGTM
8 years, 4 months ago (2012-08-07 18:38:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/10825111/12001
8 years, 4 months ago (2012-08-07 18:50:30 UTC) #13
commit-bot: I haz the power
Try job failure for 10825111-12001 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-07 19:00:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/10825111/20
8 years, 4 months ago (2012-08-07 19:18:52 UTC) #15
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 21:17:40 UTC) #16
Change committed as 150411

Powered by Google App Engine
This is Rietveld 408576698