Add default testing command line flags in UITestBase instead of ProxyLauncher.

Add default testing command line flags in UITestBase instead of ProxyLauncher.

This is particularly needed because one of the WebDriver users wants to test
with shiftshader, which is disabled because of the skip-gpu-data-loading flag.
This change makes logical sense too, since ideally ProxyLauncher should
be limited to understanding how to launch and connect to Chrome.
BUG=chromedriver:125
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150651

[kkania, 2012-08-02 21:59:43]

The comment in UITestBase::SetLaunchSwitches seems to say that I need to call
PrepareBrowserCommandLineForTests from pyauto too for chromeos. Is this correct
Nirnimesh? How come UITestBase::SetUp isn't called on chromeos?

The alternative for this CL would be too add another option to the Proxy
launcher launch options to tell it to tell PrepareBrowserCommandLineForTests not
to add the skip-gpu-data-loading flag.

[Nirnimesh, 2012-08-02 23:03:50]

LGTM

On 2012/08/02 21:59:43, kkania wrote:
> The comment in UITestBase::SetLaunchSwitches seems to say that I need to call
> PrepareBrowserCommandLineForTests from pyauto too for chromeos. Is this
correct
> Nirnimesh? How come UITestBase::SetUp isn't called on chromeos?

the browser is not launched through by ui_test/launcher on chromeos, which is
why it has no effect. pyauto needs to pass over extra chrome flags over dbus
messages to the session_manager, which happens in pyauto.py

> 
> The alternative for this CL would be too add another option to the Proxy
> launcher launch options to tell it to tell PrepareBrowserCommandLineForTests
not
> to add the skip-gpu-data-loading flag.

Please ensure that pyauto continues to work.

[kkania, 2012-08-06 16:52:09]

Adding John for owners review of chrome/test/automation.

[jam, 2012-08-06 16:57:13]

lgtm

[commit-bot: I haz the power, 2012-08-08 18:16:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkania@chromium.org/10825109/1

[commit-bot: I haz the power, 2012-08-08 19:45:25]

Try job failure for 10825109-1 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-08 23:16:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkania@chromium.org/10825109/7005

[commit-bot: I haz the power, 2012-08-09 00:28:09]

Change committed as 150651