Issue 10825108: Remove a bunch of dead fields found by Scythe.

Issue 10825108: Remove a bunch of dead fields found by Scythe. (Closed)

Created:
8 years, 4 months ago by Ami GONE FROM CHROMIUM

Modified:
8 years, 4 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove a bunch of dead fields found by Scythe. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149251

Patch Set 1 #

Total comments: 3

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -34 lines)			Patch
M	media/audio/audio_input_controller_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/audio/audio_parameters.h	View	1 chunk	+6 lines, -6 lines	3 comments	Download
M	media/audio/cross_process_notification_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/base/pipeline_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/base/simd/convert_yuv_to_rgb_c.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	media/filters/dummy_demuxer.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	media/filters/dummy_demuxer.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/filters/ffmpeg_demuxer.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/tools/tile_render_bench/tile_render_bench.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/webm/webm_cluster_parser.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	media/webm/webm_stream_parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/webm/webm_tracks_parser.h	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	media/webm/webm_tracks_parser.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

LGTM https://chromiumcodereview.appspot.com/10825108/diff/1/media/audio/audio_parameters.h File media/audio/audio_parameters.h (right): https://chromiumcodereview.appspot.com/10825108/diff/1/media/audio/audio_parameters.h#newcode45 media/audio/audio_parameters.h:45: // CD sampling rate is 44.1 KHz or ...

8 years, 4 months ago (2012-07-31 18:09:42 UTC) #2

Ami GONE FROM CHROMIUM

https://chromiumcodereview.appspot.com/10825108/diff/1/media/audio/audio_parameters.h File media/audio/audio_parameters.h (right): https://chromiumcodereview.appspot.com/10825108/diff/1/media/audio/audio_parameters.h#newcode45 media/audio/audio_parameters.h:45: // CD sampling rate is 44.1 KHz or conveniently ...

8 years, 4 months ago (2012-07-31 18:14:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10825108/1

8 years, 4 months ago (2012-07-31 18:15:03 UTC) #4

Ami GONE FROM CHROMIUM

8 years, 4 months ago (2012-07-31 20:23:55 UTC) #6

https://chromiumcodereview.appspot.com/10825108/diff/1/media/audio/audio_para...
File media/audio/audio_parameters.h (right):

https://chromiumcodereview.appspot.com/10825108/diff/1/media/audio/audio_para...
media/audio/audio_parameters.h:45: // CD sampling rate is 44.1 KHz or
conveniently 2x2x3x3x5x5x7x7.
On 2012/07/31 18:14:43, Ami Fischman wrote:
> On 2012/07/31 18:09:42, acolwell wrote:
> > nit: remove everything after the or?
> 
> Dunno where this came from, leaving for now.

FTR, this was introduced in http://codereview.chromium.org/17401; cpu@ says no
reason to keep so I'll drop it in another CL.

Expand Messages | Collapse Messages