Remove the use of urllib for SSL connections

Remove the use of urllib for SSL connections

Using urllib for SSL connections when behind a proxy is known to be
broken.

Upstream has fixed this in urllib2 in Python 2.6.3 and newer so
replace uses of urllib for SSL connections with urllib2 methods.

R=maruel@chromium.org
BUG=134165
TEST=gclient sync behind corporate proxy. Submitting this CL with git_cl.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149742

[M-A Ruel, 2012-08-01 13:57:21]

http://chromiumcodereview.appspot.com/10825107/diff/1/git_cl.py
File git_cl.py (right):

http://chromiumcodereview.appspot.com/10825107/diff/1/git_cl.py#newcode759
git_cl.py:759: with open(destination, 'w+') as f:
Why more 'w+'? Please use 'w'

Also add a doctring explaining the reason of this code, basically what you wrote
in the CL description. E.g.
"""Work around SSL connection behind an http proxy on python <2.6.3."""

Actually, I'd like you to look at sys.version and call the original function
otherwise.

[joshuagl, 2012-08-01 18:50:20]

http://chromiumcodereview.appspot.com/10825107/diff/1/git_cl.py
File git_cl.py (right):

http://chromiumcodereview.appspot.com/10825107/diff/1/git_cl.py#newcode759
git_cl.py:759: with open(destination, 'w+') as f:
On 2012/08/01 13:57:21, Marc-Antoine Ruel wrote:
> Why more 'w+'? Please use 'w'
>
> Also add a doctring explaining the reason of this code, basically what you
wrote
> in the CL description. E.g.
> """Work around SSL connection behind an http proxy on python <2.6.3."""

Will do both of the above.

> Actually, I'd like you to look at sys.version and call the original function
> otherwise.

Sadly, that won't work - I was seeing urlretrieve() fail with Python 2.7.3.

AIUI urllib is still broken in Python 2.7, only urllib2 was fixed for the SSL
issues -> urlretrieve() in urllib uses the broken urllib.urlopen() and the
urlretrieve() method doesn't exist in urllib2.

I wondered about providing a custom URLOpener subclass to urllib using urllib2
but it's a non-trivial amount of code (for Python) and started feeling a bit
like Yak shaving.

[M-A Ruel, 2012-08-02 23:39:14]

lgtm

[commit-bot: I haz the power, 2012-08-02 23:39:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joshua.lock@intel.com/10825107/5001

[commit-bot: I haz the power, 2012-08-02 23:41:52]

Change committed as 149742