Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 10825104: roll clang 159409:160967 (Closed)

Created:
8 years, 4 months ago by Nico
Modified:
8 years, 4 months ago
Reviewers:
hans
CC:
chromium-reviews, fischman+watch_chromium.org, glotov+watch_chromium.org, pam+watch_chromium.org, ukai+watch_chromium.org, Alexander Potapenko
Visibility:
Public.

Description

roll clang 159409:160967 * Lets -Wunused-private-field find more stuff * Fixes an ASan problem on precise * Improves the plugin's handling of inner classes (off by default, can be enabled with |-Xclang -plugin-arg-find-bad-constructs -Xclang check-inner-classes|) * Makes addr2line much faster on linux BUG=139346 TBR=mark for base (the change was reviewed as part of https://chromiumcodereview.appspot.com/10833055/) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149286

Patch Set 1 #

Patch Set 2 : mac #

Patch Set 3 : mac compile #

Patch Set 4 : more mac compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M base/process_util_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/mac/objc_zombie.mm View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Nico
Let's see what goes wrong this time! (so far: the goma uploader stopped running for ...
8 years, 4 months ago (2012-07-31 15:56:56 UTC) #1
hans
On 2012/07/31 15:56:56, Nico wrote: > Let's see what goes wrong this time! (so far: ...
8 years, 4 months ago (2012-07-31 16:00:36 UTC) #2
Nico
It sounds like this clang might have issues with 32bit asan. This affects the mac ...
8 years, 4 months ago (2012-07-31 17:17:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10825104/2001
8 years, 4 months ago (2012-07-31 17:18:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10825104/10002
8 years, 4 months ago (2012-07-31 18:29:50 UTC) #5
commit-bot: I haz the power
Try job failure for 10825104-10002 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-07-31 18:59:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10825104/10003
8 years, 4 months ago (2012-07-31 19:05:14 UTC) #7
commit-bot: I haz the power
Try job failure for 10825104-10003 (retry) on mac_rel for steps "base_unittests, browser_tests, cacheinvalidation_unittests, jingle_unittests, remoting_unittests, ...
8 years, 4 months ago (2012-07-31 20:03:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10825104/10003
8 years, 4 months ago (2012-07-31 20:42:30 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 21:59:21 UTC) #10
Change committed as 149286

Powered by Google App Engine
This is Rietveld 408576698