Chromium Code Reviews

Unified Diff: src/heap.h

Issue 10825099: Use architecture-specific alignment for hashing in Descriptor lookup cache. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: u Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap.h
diff --git a/src/heap.h b/src/heap.h
index 918e25efb5a98a3f84a2acd4090db364af93028c..8d40bd9a091dc4ac0c6cfa524600cba51409c88f 100644
--- a/src/heap.h
+++ b/src/heap.h
@@ -2395,9 +2395,11 @@ class DescriptorLookupCache {
static int Hash(DescriptorArray* array, String* name) {
// Uses only lower 32 bits if pointers are larger.
uint32_t array_hash =
- static_cast<uint32_t>(reinterpret_cast<uintptr_t>(array)) >> 2;
+ static_cast<uint32_t>(reinterpret_cast<uintptr_t>(array))
+ >> kPointerSizeLog2;
uint32_t name_hash =
- static_cast<uint32_t>(reinterpret_cast<uintptr_t>(name)) >> 2;
+ static_cast<uint32_t>(reinterpret_cast<uintptr_t>(name))
+ >> kPointerSizeLog2;
return (array_hash ^ name_hash) % kLength;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine