Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 10825095: add drive-internals to the list of URLs in chrome://about (Closed)

Created:
8 years, 4 months ago by Haruki Sato (Google.com)
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add chrome://drive-internals to the list of URLs in chrome://about BUG=139769 TEST=manually open the page and test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/browser_about_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Haruki Sato (Google.com)
8 years, 4 months ago (2012-07-31 08:00:27 UTC) #1
kochi
lgtm
8 years, 4 months ago (2012-07-31 08:00:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@google.com/10825095/1
8 years, 4 months ago (2012-07-31 08:00:59 UTC) #3
commit-bot: I haz the power
Presubmit check for 10825095-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-31 08:01:01 UTC) #4
Haruki Sato (Google.com)
Ben, could you review this change as an OWNER? Thanks.
8 years, 4 months ago (2012-07-31 08:13:33 UTC) #5
Haruki Sato (Google.com)
Adding jhawkins@ in case Ben is not available. James, could you take a look at ...
8 years, 4 months ago (2012-08-02 01:42:16 UTC) #6
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-02 15:26:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@google.com/10825095/1
8 years, 4 months ago (2012-08-03 02:00:40 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 03:20:46 UTC) #9
Change committed as 149795

Powered by Google App Engine
This is Rietveld 408576698