Fix regression due to deprecated promo preference.

Fix regression due to deprecated promo preference.

148013 introduced a regression where the promo text was not being set, because it referred to a deprecated promo pref.

BUG=123061
TEST=manual.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149264

[achuithb, 2012-07-31 01:07:39]

Please review, Ruslan

[aruslan, 2012-07-31 01:26:40]

LGTM with exception of the first_run::IsChromeFirstRun(): please ask PMs whether
this is something we want on all platforms, and/or should we have an option for
it in JSON.

[achuithb, 2012-07-31 01:31:47]

On 2012/07/31 01:26:40, aruslan wrote:
> LGTM with exception of the first_run::IsChromeFirstRun(): please ask PMs
whether
> this is something we want on all platforms, and/or should we have an option
for
> it in JSON.

Thanks for the review. I'll wait to hear back.

[achuithb, 2012-07-31 09:01:47]

Ruslan: I think we'll need to put the first run behavior behind a server control
since we may need to suppress it in some situations and not in others. I've
removed that for now. PTAL.

Rob: Please take a look. Thanks!

[Robert Sesek, 2012-07-31 14:46:34]

LGTM

[achuithb, 2012-07-31 17:55:55]

Dan, need owner lgtm for ntp_resource_cache.cc

[Dan Beam, 2012-07-31 18:27:03]

lgtm assuming it compiles, you might consider adding some type of integration
test to see if CanShow() returns true if
!load_time_data.GetString("serverpromo").empty() and vice versa...

[achuithb, 2012-07-31 18:30:21]

On 2012/07/31 18:27:03, Dan Beam wrote:
> lgtm assuming it compiles, you might consider adding some type of integration
> test to see if CanShow() returns true if
> !load_time_data.GetString("serverpromo").empty() and vice versa...

Yup, we need a browser test..

[commit-bot: I haz the power, 2012-07-31 19:09:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/10825093/10001

[commit-bot: I haz the power, 2012-07-31 20:21:10]

Change committed as 149264