Issue 10825086: ash: Update window frame art and transparency values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825086: ash: Update window frame art and transparency values (Closed)

Created:
8 years, 4 months ago by James Cook

Modified:
8 years, 4 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Update window frame art and transparency values Per kuscher@ we'd like to try: * Active and inactive windows 100% opaque * Solo window 30% opaque * New art assets for active and inactive window frames BUG=137340 TEST=visual, with 2 windows open the active window should have an opaque darker frame and the inactive window should have an opaque lighter frame Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149006

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -1 line)			Patch
M	ash/wm/frame_painter.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
A	chrome/app/theme/default_100_percent/ash/theme_frame_active.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/ash/theme_frame_default_active.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/ash/theme_frame_default_inactive.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/default_100_percent/ash/theme_frame_inactive.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

James Cook

Dan, PTAL. I've reviewed the visuals with kuscher@ and sgabriel@. There aren't any try jobs ...

8 years, 4 months ago (2012-07-30 20:06:58 UTC) #1

lgtm

Expand Messages | Collapse Messages