Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10825085: Move RunAllPendingInMessageLoop from ui_test_utils.h to test_utils.h, so that it can be reused by c… (Closed)

Created:
8 years, 4 months ago by jam
Modified:
8 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, MAD, sadrul, nkostylev+watch_chromium.org, rginda+watch_chromium.org, Ilya Sherman, ncarter (slow), jar (doing other things), ben+watch_chromium.org, stevenjb+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), Raghu Simha, oshima+watch_chromium.org, mihaip-chromium-reviews_chromium.org, akalin, tfarina, Aaron Boodman, rdsmith+dwatch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move RunAllPendingInMessageLoop from ui_test_utils.h to test_utils.h, so that it can be reused by content_browsertests. I put it in test_utils.h instead of browser_test_utils.h because this is also used by unit tests. BUG=90448 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149026

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -183 lines) Patch
M chrome/browser/browser_focus_uitest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_notifications_browsertest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/network_screen_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui/idle_logout_dialog_view_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_danger_prompt_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/android/android_provider_backend_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_layout_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/protector/protector_service_browsertest.cc View 47 chunks +53 lines, -53 lines 0 comments Download
M chrome/browser/sync/test/integration/sessions_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_close_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/global_error/global_error_service_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/launcher/launcher_favicon_loader_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/ui_test_utils.h View 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 2 3 4 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/public/test/test_utils.h View 2 chunks +11 lines, -0 lines 0 comments Download
M content/test/test_utils.cc View 1 2 3 3 chunks +31 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
8 years, 4 months ago (2012-07-30 20:17:22 UTC) #1
scottmg
lgtm http://codereview.chromium.org/10825085/diff/3003/content/test/test_utils.cc File content/test/test_utils.cc (right): http://codereview.chromium.org/10825085/diff/3003/content/test/test_utils.cc#newcode41 content/test/test_utils.cc:41: RunMessageLoop(); Replace 39-41 with content::RunAllPendingInMessageLoop()?
8 years, 4 months ago (2012-07-30 20:23:26 UTC) #2
jam
8 years, 4 months ago (2012-07-30 20:34:21 UTC) #3 
http://codereview.chromium.org/10825085/diff/3003/content/test/test_utils.cc
File content/test/test_utils.cc (right):

http://codereview.chromium.org/10825085/diff/3003/content/test/test_utils.cc#...
content/test/test_utils.cc:41: RunMessageLoop();
On 2012/07/30 20:23:26, scottmg wrote:
> Replace 39-41 with content::RunAllPendingInMessageLoop()?

Done.

Powered by Google App Engine
This is Rietveld 408576698