Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 10825080: Add support for Sawbuck to Content Shell (ETW tracing). (Closed)

Created:
8 years, 4 months ago by tommi (sloooow) - chröme
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add support for Sawbuck to Content Shell (ETW tracing). Until Sawbuck gets updated (I plan to do that soon), devs have to add a few registry entries for this to work, but that's simple to do and a one time thing per machine and the instructions are in the code. TEST=Content Shell and Sawbuck should work together (see above). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M content/shell/shell_main_delegate.cc View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tommi (sloooow) - chröme
Siggi: main reviewer. Darin: owner.
8 years, 4 months ago (2012-07-30 16:52:42 UTC) #1
Sigurður Ásgeirsson
lgtm
8 years, 4 months ago (2012-07-30 17:09:26 UTC) #2
darin (slow to review)
LGTM
8 years, 4 months ago (2012-07-31 21:12:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/10825080/1
8 years, 4 months ago (2012-07-31 21:19:49 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 22:20:12 UTC) #5
Change committed as 149294

Powered by Google App Engine
This is Rietveld 408576698