Fix the candidate window position of IME in Retina display.

Fix the candidate window position of IME in Retina display.

BUG=139108
TEST=manually done


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148916

[horo, 2012-07-29 02:07:30]

Please review this cl.

[Avi (use Gerrit), 2012-07-29 02:11:37]

LGTM

I repeatedly searched the codebase for convertRectToBase; how did I miss this?

[Nico, 2012-07-29 02:12:03]

lgtm2

https://chromiumcodereview.appspot.com/10825070/diff/1/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://chromiumcodereview.appspot.com/10825070/diff/1/content/browser/render...
content/browser/renderer_host/render_widget_host_view_mac.mm:2815: rect.origin.y
= NSHeight(viewFrame) - rect.origin.y;
nit: Change this line to

   ... = NSHeight(viewFrame) - NSMaxY(rect);

and delete the next line while you're here?

[horo, 2012-07-29 02:40:07]

https://chromiumcodereview.appspot.com/10825070/diff/1/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://chromiumcodereview.appspot.com/10825070/diff/1/content/browser/render...
content/browser/renderer_host/render_widget_host_view_mac.mm:2815: rect.origin.y
= NSHeight(viewFrame) - rect.origin.y;
On 2012/07/29 02:12:04, Nico wrote:
> nit: Change this line to
> 
>    ... = NSHeight(viewFrame) - NSMaxY(rect);
> 
> and delete the next line while you're here?

Done.

[commit-bot: I haz the power, 2012-07-29 02:41:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/horo@chromium.org/10825070/2002

[Nico, 2012-07-29 02:44:34]

LGTM!

[commit-bot: I haz the power, 2012-07-29 18:09:49]

Change committed as 148916