Issue 10825069: Change ShareableFileReference to take TaskRunner instead of MessageLoopProxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825069: Change ShareableFileReference to take TaskRunner instead of MessageLoopProxy (Closed)

Created:
8 years, 4 months ago by kinuko

Modified:
8 years, 4 months ago

Reviewers:
michaeln, tzik

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Change ShareableFileReference to take TaskRunner instead of MessageLoopProxy BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148893

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -11 lines)			Patch
	M	webkit/blob/shareable_file_reference.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
	M	webkit/blob/shareable_file_reference.cc	View		5 chunks	+9 lines, -7 lines	0 comments	Download

Total messages: 6 (0 generated)

kinuko

Michael, I'm submitting this but let me know if this doesn't look good.

8 years, 4 months ago (2012-07-28 04:31:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/10825069/1

8 years, 4 months ago (2012-07-28 04:31:24 UTC) #4

lgtm2