Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10825068: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed)

Created:
8 years, 4 months ago by rpetterson
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. BUG=112525 TEST=unittests, manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149554

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -16 lines) Patch
M chrome/browser/sync/glue/bookmark_change_processor.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc View 1 2 10 chunks +21 lines, -9 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rpetterson
8 years, 4 months ago (2012-07-27 23:41:02 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 4 months ago (2012-07-30 21:02:29 UTC) #2
rpetterson
ping atwilson . . .
8 years, 4 months ago (2012-07-30 23:43:08 UTC) #3
Andrew T Wilson (Slow)
LGTM with one nit. http://codereview.chromium.org/10825068/diff/7002/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc File chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc (right): http://codereview.chromium.org/10825068/diff/7002/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc#newcode49 chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc:49: ProfileKeyedService* BuildBookmarkModel( We should make ...
8 years, 4 months ago (2012-07-31 23:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10825068/5006
8 years, 4 months ago (2012-08-02 00:17:57 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 01:20:20 UTC) #6
Change committed as 149554

Powered by Google App Engine
This is Rietveld 408576698