chrome/common/extensions/docs/server2/templates/private/sample_item.html - Issue 10825067: Extensions Docs Server: Apps samples page

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/server2/templates/private/sample_item.html

Issue 10825067: Extensions Docs Server: Apps samples page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixes Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <div class="sample" tags="{{#api_calls}}{{name}} {{/}}">

	2 <img class="icon" src="{{icon}}">

	3 <h2><a href="{{?is_apps}}{{github_path}}{{:}}{{path}}.zip{{/}}">{{name}}</a></ h2>
	not at google - send to devlin 2012/08/10 06:02:18 Why do we need github_path at all? Can we just mak Why do we need github_path at all? Can we just make sure that it's set right from samples_data_source? Perhaps call it url. Then we wouldn't need is_apps. Woo. cduvall 2012/08/10 21:17:47 Done. Show quoted text On 2012/08/10 06:02:18, kalman wrote: > Why do we need github_path at all? Can we just make sure that it's set right > from samples_data_source? > > Perhaps call it url. > > Then we wouldn't need is_apps. Woo. Done.
	4 {{description}}

	5 <div>

	6 <span class="label">Calls:</span>

	7 <ul>

	8 {{#api_calls}}

	9 <li><code><a href="{{link}}">{{name}}</a></code></li>

	10 {{/}}

	11 </ul>

	12 </div>

	13 <div>

	14 <span class="label">Source Files:</span>

	15 <ul>

	16 {{#files}}

	17 <li><code><a href="{{?is_apps}}{{github_path}}{{:}}{{path}}{{/}}/{{@}}">{{ @}}</a></code></li>

	18 {{/}}

	19 </ul>

	20 </div>

	21 </div>

OLD	NEW