Issue 10825066: Don't allow processing of a command buffer to overlap with a previous swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825066: Don't allow processing of a command buffer to overlap with a previous swap. (Closed)

Created:
8 years, 4 months ago by jbauman

Modified:
8 years, 4 months ago

Reviewers:
apatrick_chromium, jbates

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't allow processing of a command buffer to overlap with a previous swap. This may be causing some synchronization problems, so disable it for now to see if that fixes it. BUG=135546 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149038

Patch Set 1 #

Total comments: 1

Patch Set 2 : add bug url #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	content/common/gpu/image_transport_surface_win.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jbates

LGTM https://chromiumcodereview.appspot.com/10825066/diff/1/content/common/gpu/image_transport_surface_win.cc File content/common/gpu/image_transport_surface_win.cc (right): https://chromiumcodereview.appspot.com/10825066/diff/1/content/common/gpu/image_transport_surface_win.cc#newcode203 content/common/gpu/image_transport_surface_win.cc:203: // Pause all processing of this command buffer. ...

8 years, 4 months ago (2012-07-27 21:39:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/10825066/5001

8 years, 4 months ago (2012-07-30 18:49:01 UTC) #5

Change committed as 149038

Expand Messages | Collapse Messages