Issue 10825059: Fix memory leak

Issue 10825059: Fix memory leak (Closed)

Created:
8 years, 4 months ago by mathp

Modified:
8 years, 4 months ago

Reviewers:
Roger Tawa OOO till Jul 10th, Andrew T Wilson (Slow), tim (not reviewing), lipalani1

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Change a Value pointer to a scoped_ptr to avoid memory leak. Fixes error returned from memory bot. Fix for https://chromiumcodereview.appspot.com/10555005 BUG=118280 TEST=Same test scenarios as in change 10555005. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148841

Patch Set 2 : get() on scoped_ptr #

Patch Set 4 : passing the value #

Total comments: 1

Patch Set 5 : removing.get() #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/ui/sync/one_click_signin_helper.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Roger Tawa OOO till Jul 10th

lgtm https://chromiumcodereview.appspot.com/10825059/diff/8001/chrome/browser/ui/sync/one_click_signin_helper.cc File chrome/browser/ui/sync/one_click_signin_helper.cc (right): https://chromiumcodereview.appspot.com/10825059/diff/8001/chrome/browser/ui/sync/one_click_signin_helper.cc#newcode273 chrome/browser/ui/sync/one_click_signin_helper.cc:273: *email_value.get()); nit: replace with *email_value

8 years, 4 months ago (2012-07-27 19:31:56 UTC) #1

mathp

On 2012/07/27 19:31:56, Roger Tawa wrote: > lgtm > > https://chromiumcodereview.appspot.com/10825059/diff/8001/chrome/browser/ui/sync/one_click_signin_helper.cc > File chrome/browser/ui/sync/one_click_signin_helper.cc (right): ...

8 years, 4 months ago (2012-07-27 20:01:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@google.com/10825059/7003

8 years, 4 months ago (2012-07-27 21:19:26 UTC) #4

Change committed as 148841

Expand Messages | Collapse Messages